On tor, 2011-02-03 at 00:10 -0500, Noah Misch wrote:
> > This is good stuff. I'll send you a new patch in a day or three for
> > perhaps another round of performance tests. Some of the other
> issues
> > above can perhaps be postponed for follow-up patches.
>
> I agree -- if the performance-when-unused gets solid, none of my other
> comments ought to hold things up.
Here is a new patch.
The main change is in varstr_cmp(), avoiding the calls to
pg_newlocale_from_collation() when the default locale is used. This
accounts for the performance regression in my tests. It also addresses
some of your refactoring ideas.
