Postgres Pro
Downloads
Home   >   mailing lists

Re: Recently added typedef "string" is a horrid idea - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Recently added typedef "string" is a horrid idea
Date
Msg-id 12942.1454860075@sss.pgh.pa.us
Whole thread Raw
In response to Re: Recently added typedef "string" is a horrid idea  (Peter Geoghegan <pg@heroku.com>)
Responses Re: Recently added typedef "string" is a horrid idea
List pgsql-hackers
Tree view 
Peter Geoghegan <pg@heroku.com> writes:
> On Sat, Feb 6, 2016 at 2:11 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> Please rename this typedef with some less-generic name.  Probably
>> some of the other identifiers added in the same commit should be
>> adjusted to match.

> I suggest "VarString". All the text SortSupport routines were renamed
> to match a pattern of "varstr.*" as part of the commit you mention.

Works for me.
        regards, tom lane

pgsql-hackers by date:

Previous
From: Vik Fearing
Date:
Subject: Re: proposal: make NOTIFY list de-duplication optional
Next
From: Peter Geoghegan
Date:
Subject: Re: Using quicksort for every external sort run