Re: Assertion failure on hot standby - Mailing list pgsql-hackers

From Simon Riggs
Subject Re: Assertion failure on hot standby
Date
Msg-id 1290993263.4634.3142.camel@ebony
Whole thread Raw
In response to Re: Assertion failure on hot standby  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
On Fri, 2010-11-26 at 01:11 -0500, Tom Lane wrote:
> Simon Riggs <simon@2ndQuadrant.com> writes:
> > That would mean running GetCurrentTransactionId() inside LockAcquire()
> 
> > if (lockmode >= AccessExclusiveLock &&
> >     locktag->locktag_type == LOCKTAG_RELATION &&
> >     !RecoveryInProgress())
> >     (void) GetCurrentTransactionId();
> 
> > Any objections to that fix?
> 
> Could we have a wal level test in there too please?  It's pretty awful
> in any case...

Slightly neater version of same idea applied to resolve this.

-- Simon Riggs           http://www.2ndQuadrant.com/books/PostgreSQL Development, 24x7 Support, Training and Services



pgsql-hackers by date:

Previous
From: Itagaki Takahiro
Date:
Subject: Re: Patch to add a primary key using an existing index
Next
From: Robert Haas
Date:
Subject: Re: profiling connection overhead