Re: fairywren is generating bogus BASE_BACKUP commands - Mailing list pgsql-hackers

From Tom Lane
Subject Re: fairywren is generating bogus BASE_BACKUP commands
Date
Msg-id 1289349.1642804965@sss.pgh.pa.us
Whole thread Raw
In response to Re: fairywren is generating bogus BASE_BACKUP commands  (Andrew Dunstan <andrew@dunslane.net>)
Responses Re: fairywren is generating bogus BASE_BACKUP commands
Re: fairywren is generating bogus BASE_BACKUP commands
List pgsql-hackers
Andrew Dunstan <andrew@dunslane.net> writes:
> c.f. src/bin/pg_verifybackup/t/003_corruption.pl which says:
>     my $source_ts_prefix = $source_ts_path;
>     $source_ts_prefix =~ s!(^[A-Z]:/[^/]*)/.*!$1!;
>     ...

>     # See https://www.msys2.org/wiki/Porting/#filesystem-namespaces
>     local $ENV{MSYS2_ARG_CONV_EXCL} = $source_ts_prefix;

> Probably in this case just setting it to 'server:' would do the trick.

The point I was trying to make is that if we have to jump through
that sort of hoop in the test scripts, then real users are going
to have to jump through it as well, and they won't like that
(and we will get bug reports about it).  It'd be better to design
the option syntax to avoid such requirements.

            regards, tom lane



pgsql-hackers by date:

Previous
From: John Naylor
Date:
Subject: Re: do only critical work during single-user vacuum?
Next
From: Andres Freund
Date:
Subject: Re: New developer papercut - Makefile references INSTALL