Re: [PATCH] Avoid collation lookup for "char" statistics - Mailing list pgsql-hackers

From Tom Lane
Subject Re: [PATCH] Avoid collation lookup for "char" statistics
Date
Msg-id 1287409.1782528247@sss.pgh.pa.us
Whole thread
In response to [PATCH] Avoid collation lookup for "char" statistics  (Feng Wu <wufengwufengwufeng@gmail.com>)
Responses Re: [PATCH] Avoid collation lookup for "char" statistics
List pgsql-hackers
Feng Wu <wufengwufengwufeng@gmail.com> writes:
> The internal "char" type is not collatable, and its btree operators
> order the byte value directly.  Return the one-byte string for CHAROID
> without consulting collation state, avoiding a lookup of InvalidOid as
> collation 0.

Can you demonstrate that there is a problem worth worrying about here?
We've had no field reports of failures in this code, and I don't see
a problem with, e.g.

 explain select * from pg_type a join pg_type b using (typtype);

            regards, tom lane



pgsql-hackers by date:

Previous
From: Dilip Kumar
Date:
Subject: Re: Proposal: Conflict log history table for Logical Replication
Next
From: "ZizhuanLiu X-MAN"
Date:
Subject: Re: Reject ADD CONSTRAINT NOT NULL if name mismatches existing domain not-null constraint