Re: Latches, loop and exit - Mailing list pgsql-hackers

From Simon Riggs
Subject Re: Latches, loop and exit
Date
Msg-id 1284531556.1952.4734.camel@ebony
Whole thread Raw
In response to Re: Latches, loop and exit  (Fujii Masao <masao.fujii@gmail.com>)
Responses Re: Latches, loop and exit  (Fujii Masao <masao.fujii@gmail.com>)
Re: Latches, loop and exit  (Heikki Linnakangas <heikki.linnakangas@enterprisedb.com>)
List pgsql-hackers
On Wed, 2010-09-15 at 10:33 +0900, Fujii Masao wrote:
> On Wed, Sep 15, 2010 at 12:14 AM, Simon Riggs <simon@2ndquadrant.com> wrote:
> >
> > Like latches, nice one.
> >
> > The way the loop in WalSender now happens it won't send any outstanding
> > WAL if a shutdown is requested while it is waiting.
> >
> > That probably needs to change and we'd do similarly in other procs.
> 
> Really? ISTM that walsender tries to send all outstanding WAL without
> problems after it receives SIGUSR2. Am I missing something?

For SIGUSR2, you're right.

However, if the following clause is ever invoked, then the loop does
have problems and we leave when not caught up.

if (!PostmasterIsAlive(true))exit(1);

-- Simon Riggs           www.2ndQuadrant.comPostgreSQL Development, 24x7 Support, Training and Services



pgsql-hackers by date:

Previous
From: SAKAMOTO Masahiko
Date:
Subject: patch: SQL/MED(FDW) DDL
Next
From: Fujii Masao
Date:
Subject: Re: Latches, loop and exit