Request a Demo
Home   >   mailing lists

Re: Use \if/\endif to remove non-libxml2 expected output in regression tests - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Use \if/\endif to remove non-libxml2 expected output in regression tests
Date
Msg-id 128417.1781480034@sss.pgh.pa.us
Whole thread
In response to Re: Use \if/\endif to remove non-libxml2 expected output in regression tests  (Michael Paquier <michael@paquier.xyz>)
Responses Re: Use \if/\endif to remove non-libxml2 expected output in regression tests
List pgsql-hackers
Tree view 
Michael Paquier <michael@paquier.xyz> writes:
> On Sun, Jun 14, 2026 at 07:12:24PM -0400, Tom Lane wrote:
>> I think it's worth covering, say, one of those paths, but we don't
>> have to hit every one of the duplicate copies.  So what do you think
>> of putting the early-exit \if after the first test that produces
>> one of those failures?

> Positioning the \if after the three initial INSERT queries (\if query
> that counts the number of tuples inserted), like in the patch I have
> posted upthread, is able to hit NO_XML_SUPPORT() in xmlin().  That
> would be enough.  Would you agree with that?

Works for me.

            regards, tom lane

pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: Use \if/\endif to remove non-libxml2 expected output in regression tests
Next
From: Michael Paquier
Date:
Subject: Re: injection_points: Switch wait/wakeup to use atomics rather than latches