Re: CommitFest 2009-07: Yay, Kevin! Thanks, reviewers! - Mailing list pgsql-hackers

From Alvaro Herrera
Subject Re: CommitFest 2009-07: Yay, Kevin! Thanks, reviewers!
Date
Msg-id 1282230425-sup-8258@alvh.no-ip.org
Whole thread Raw
In response to Re: CommitFest 2009-07: Yay, Kevin! Thanks, reviewers!  (Heikki Linnakangas <heikki.linnakangas@enterprisedb.com>)
Responses Re: CommitFest 2009-07: Yay, Kevin! Thanks, reviewers!
Re: CommitFest 2009-07: Yay, Kevin! Thanks, reviewers!
List pgsql-hackers
Excerpts from Heikki Linnakangas's message of jue ago 19 02:02:34 -0400 2010:
> On 19/08/10 04:46, Robert Haas wrote:

> >  And so far we haven't seen a patch for that.
> > Somebody write one.  And then let's get it reviewed and committed RSN.
> 
> Fujii is on vacation, but I've started working on it. The two issues 
> with Fujii's latest patch are that it would not respond promptly on 
> platforms where signals don't interrupt sleep, and it suffers the 
> classic race condition that pselect() was invented for. I'm going to 
> replace pg_usleep() with select(), and use the so called "self-pipe 
> trick" to get over the race condition. I have that written up but I want 
> to do some testing and cleanup before posting the patch.

Hmm, IIRC the self-pipe trick doesn't work on Windows, mainly because
select() doesn't handle pipes, only sockets.  You may need some extra
hack to make it work there.

-- 
Álvaro Herrera <alvherre@commandprompt.com>
The PostgreSQL Company - Command Prompt, Inc.
PostgreSQL Replication, Consulting, Custom Development, 24x7 support


pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: Re: [COMMITTERS] pgsql: Coerce 'unknown' type parameters to the right type in the
Next
From: Robert Haas
Date:
Subject: Re: refactoring comment.c