Re: need more ALTER TABLE guards for typed tables - Mailing list pgsql-hackers

From Alvaro Herrera
Subject Re: need more ALTER TABLE guards for typed tables
Date
Msg-id 1279741672-sup-9800@alvh.no-ip.org
Whole thread Raw
In response to need more ALTER TABLE guards for typed tables  (Peter Eisentraut <peter_e@gmx.net>)
Responses Re: need more ALTER TABLE guards for typed tables
List pgsql-hackers
Excerpts from Peter Eisentraut's message of mié jul 21 15:18:58 -0400 2010:
> After some investigation I figured that I need to add two more checks
> into the ALTER TABLE code to prevent certain types of direct changes to
> typed tables (see attached patch).
> 
> But it's not clear to me whether such checks should go into the "Prep"
> or the "Exec" phases.  Prep seems more plausible to me, but some
> commands such as DropColumn don't have a Prep handler.  A clarification
> would be helpful.

I think if there's no Prep phase, you should add it.  I don't think it
makes sense to have this kind of check in Exec.


pgsql-hackers by date:

Previous
From: David Christensen
Date:
Subject: Re: documentation for committing with git
Next
From: Andrew Dunstan
Date:
Subject: Re: documentation for committing with git