Robert Haas <robertmhaas@gmail.com> writes:
> On Thu, Sep 15, 2016 at 11:01 AM, Anastasia Lubennikova
> <a.lubennikova@postgrespro.ru> wrote:
>> What do you think about moving stuff from pg_upgrade/file.c to storage/file/
>> to allow reuse of this code? I think it'll be really helpful for developers
>> of contrib modules
>> like backup managers.
> Well, storage/file is backend and pg_upgrade is frontend. If you want
> to reuse the same code for both it's got to go someplace else.
Also, to the extent that it's important to use those wrappers rather
than libc directly, it's because the wrappers are tied into backend
resource management and error handling conventions. I don't see how
you convert that into code that also works in a frontend program,
or what the point would be exactly.
regards, tom lane
