Re: Zero-padding and zero-masking fixes for to_char(float) - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Zero-padding and zero-masking fixes for to_char(float)
Date
Msg-id 12759.1427085385@sss.pgh.pa.us
Whole thread Raw
In response to Re: Zero-padding and zero-masking fixes for to_char(float)  (Bruce Momjian <bruce@momjian.us>)
Responses Re: Zero-padding and zero-masking fixes for to_char(float)
Re: Zero-padding and zero-masking fixes for to_char(float)
List pgsql-hackers
Bruce Momjian <bruce@momjian.us> writes:
> On Sun, Mar 22, 2015 at 12:46:08PM -0400, Noah Misch wrote:
>> I recommend adding a "configure" test to use our snprintf.c replacements if
>> sprintf("%.*f", 65536, 99999999999.0) gives unexpected output.

> Do we really want to go to our /port snprintf just to handle 512+
> digits?

I'd rather not go that direction (that is, to using a configure test).
It assumes that all copies of libc on a particular platform behave the
same, which seems like a bad bet to me.  I think we'd be better off to
avoid asking libc to do anything that might not work everywhere.

On the other hand, this line of thought might end up having you
reimplement in formatting.c the same logic I put into snprintf.c
recently, which seems a bit silly.
        regards, tom lane



pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: New functions
Next
From: Venkata Balaji N
Date:
Subject: recovery_target_time ignored ?