Re: s/recovery_connections/allow_standby_queries/, or something like that? - Mailing list pgsql-hackers

From Joshua D. Drake
Subject Re: s/recovery_connections/allow_standby_queries/, or something like that?
Date
Msg-id 1272563735.2733.14.camel@jd-desktop.unknown.charter.com
Whole thread Raw
In response to s/recovery_connections/allow_standby_queries/, or something like that?  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
On Thu, 2010-04-29 at 13:18 -0400, Tom Lane wrote:
> I've just realized that one of the confusing things about this debate
> is that the recovery_connections parameter is very confusingly named.
> It might have been okay when HS existed in isolation, but with SR in the
> mix, it's not at all clear that the parameter refers to client
> connections made to a standby server, and not to replication connections
> made from a standby to its master.  It is easy to think that this is a
> parameter that needs to be turned on in the master to allow standby
> slaves to connect to it.
>
> Another problem is that it looks more like an integer parameter
> (ie, maximum number of such connections) than a boolean.
>
> I think a different name would help.  The best idea I can come up with
> on the spur of the moment is "allow_standby_queries", but I'm not sure
> that can't be improved on.  Comments?

enable_standby_queries (nitpicky but it seems more appropriate)

Joshua D. Drake


>
>             regards, tom lane
>


--
PostgreSQL.org Major Contributor
Command Prompt, Inc: http://www.commandprompt.com/ - 503.667.4564
Consulting, Training, Support, Custom Development, Engineering

pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: s/recovery_connections/allow_standby_queries/, or something like that?
Next
From: Heikki Linnakangas
Date:
Subject: Re: Re: [COMMITTERS] pgsql: Make CheckRequiredParameterValues() depend upon correct