Re: pgsql: Add missing optimizer hooks for function cost and number of rows. - Mailing list pgsql-committers

From Simon Riggs
Subject Re: pgsql: Add missing optimizer hooks for function cost and number of rows.
Date
Msg-id 1272094276.4161.960.camel@ebony
Whole thread Raw
In response to Re: pgsql: Add missing optimizer hooks for function cost and number of rows.  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: [HACKERS] Re: pgsql: Add missing optimizer hooks for function cost and number of rows.  (Robert Haas <robertmhaas@gmail.com>)
List pgsql-committers
On Fri, 2010-04-23 at 18:55 -0400, Tom Lane wrote:
> sriggs@postgresql.org (Simon Riggs) writes:
> > Log Message:
> > -----------
> > Add missing optimizer hooks for function cost and number of rows.
> > Closely follow design of other optimizer hooks: if hook exists
> > retrieve value from plugin; if still not set then get from cache.
>
> What exactly are we doing adding new features without discussion (or
> documentation, or known use cases) at this stage of the release cycle?

Existing hooks were not fully complete in their coverage. That has
happened before, and we have discussed that before on hackers, so I took
care not to deviate from that implementation. This is a very low impact
change, isn't in a new area and similar optimizer related changes were
made recently, so I saw little to object to in this particular change.
No such hooks are documented, even ones with strong use cases.

--
 Simon Riggs           www.2ndQuadrant.com


pgsql-committers by date:

Previous
From: rhaas@postgresql.org (Robert Haas)
Date:
Subject: pgsql: Fix various instances of "the the".
Next
From: Robert Haas
Date:
Subject: Re: [HACKERS] Re: pgsql: Add missing optimizer hooks for function cost and number of rows.