Re: Use \if/\endif to remove non-libxml2 expected output in regression tests - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Use \if/\endif to remove non-libxml2 expected output in regression tests
Date
Msg-id 127189.1781478744@sss.pgh.pa.us
Whole thread
In response to Re: Use \if/\endif to remove non-libxml2 expected output in regression tests  (Michael Paquier <michael@paquier.xyz>)
Responses Re: Use \if/\endif to remove non-libxml2 expected output in regression tests
List pgsql-hackers
Michael Paquier <michael@paquier.xyz> writes:
> I would also like to drop xml_1.out with the previous trick \if, but
> at the end if you feel that there is still value in keeping some
> coverage for the multiple NO_XML_SUPPORT() paths, that's fine by me.
> Removing half of the regression output update pain is still better
> than removing none of it.

I think it's worth covering, say, one of those paths, but we don't
have to hit every one of the duplicate copies.  So what do you think
of putting the early-exit \if after the first test that produces
one of those failures?

            regards, tom lane



pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: Use \if/\endif to remove non-libxml2 expected output in regression tests
Next
From: Michael Paquier
Date:
Subject: Re: Use \if/\endif to remove non-libxml2 expected output in regression tests