Re: Fdw batch insert error out when set batch_size > 65535 - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Fdw batch insert error out when set batch_size > 65535
Date
Msg-id 1271666.1623218746@sss.pgh.pa.us
Whole thread Raw
In response to Re: Fdw batch insert error out when set batch_size > 65535  (Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>)
Responses Re: Fdw batch insert error out when set batch_size > 65535
List pgsql-hackers
Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com> writes:
>> I've added a simple regression test to postgres_fdw, testing that batch
>> sizes > 65535 work fine, and pushed the fix.

> I was earlier thinking of adding one, but stopped because it might
> increase the regression test execution time. It looks like that's true
> - with and without the test case it takes 17 sec and 4 sec
> respectively on my dev system which is 4X slower. I'm not sure if this
> is okay.

The cost, versus the odds of ever detecting a problem, doesn't
seem like a good tradeoff.

            regards, tom lane



pgsql-hackers by date:

Previous
From: Amit Kapila
Date:
Subject: Re: [HACKERS] logical decoding of two-phase transactions
Next
From: "Drouvot, Bertrand"
Date:
Subject: Re: logical decoding bug: segfault in ReorderBufferToastReplace()