Re: pgsql: Use malloc() in GetLockConflicts() when called InHotStandby to - Mailing list pgsql-committers

From Simon Riggs
Subject Re: pgsql: Use malloc() in GetLockConflicts() when called InHotStandby to
Date
Msg-id 1264693567.24669.10769.camel@ebony
Whole thread Raw
In response to Re: pgsql: Use malloc() in GetLockConflicts() when called InHotStandby to  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-committers
On Thu, 2010-01-28 at 10:43 -0500, Tom Lane wrote:
> sriggs@postgresql.org (Simon Riggs) writes:
> > Log Message:
> > -----------
> > Use malloc() in GetLockConflicts() when called InHotStandby to avoid repeated
> > palloc calls. Current code assumed this was already true, so this is a bug fix.
>
> It seems pretty ugly to allocate the same pointer sometimes with malloc
> and sometimes with palloc.  How about palloc'ing it in TopMemoryContext
> when you want it to be persistent?

Yes, that sounds more graceful. Will do.

--
 Simon Riggs           www.2ndQuadrant.com


pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: Re: pgsql: Use malloc() in GetLockConflicts() when called InHotStandby to
Next
From: Tom Lane
Date:
Subject: Re: pgsql: Define INADDR_NONE on Solaris when it's missing.