On ons, 2010-01-27 at 09:04 -0800, David Fetter wrote:
> On Wed, Jan 27, 2010 at 04:52:00PM +0200, Peter Eisentraut wrote:
> > On tis, 2010-01-26 at 10:20 -0800, David Fetter wrote:
> > > On Tue, Jan 26, 2010 at 02:21:29PM +0000, Bruce Momjian wrote:
> > > > Log Message:
> > > > -----------
> > > > Remove tabs in SGML.
> > >
> > > Can we see about making a commit hook for CVS that disallows \t in
> > > SGML files? The process in git is pretty simple.
> >
> > Better write a check in the makefile.
>
> That assumes that everyone will always actually run the appropriate
> make before committing, which I wouldn't assume, especially for a
> "trivial" patch that's going out when someone is pressed for time.
Even if you are pressed for time, you are supposed to check your patch.
And even then, we have the community and automated build services to
pick up after you.
> Checking in an unavoidable place seems much more foolproof.
I'm going to put in an advance vote here against any kind of
code-checking commit hook. Because they live in the repository
metadata, they can only be seen and changed by the system
administrators, they do not travel with the source code, and they are
not under version control themselves. The source code and the scripts
and tests to manage it should be self-consistent and not dependent on
external containers.
