Re: Hot Standby and query cancel - Mailing list pgsql-hackers

From Simon Riggs
Subject Re: Hot Standby and query cancel
Date
Msg-id 1263410429.26654.11980.camel@ebony
Whole thread Raw
In response to Re: Hot Standby and query cancel  (Andres Freund <andres@anarazel.de>)
Responses Re: Hot Standby and query cancel
List pgsql-hackers
On Wed, 2010-01-13 at 19:58 +0100, Andres Freund wrote:

> > I am still testing patch, so should be confident to commit tomorrow
> > barring issues.
> I have only looked at briefly because right now I dont have the time (going to
> eat at a friends place...) but I think I spotted an issue:
> The IsAbortedTransactionBlockState() check in RecoveryConflictInterrupt is not
> correct right now because that returns true for TBLOCK_SUBABORT as well.
> Wouldnt that mess with the case where were in a failed subxact and then
> rollback only that subxact?

Well spotted, yes.

--
 Simon Riggs           www.2ndQuadrant.com

Attachment

pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: NEED HELP !
Next
From: Stephen Frost
Date:
Subject: Re: [PATCH] remove redundant ownership checks