Re: BUG #16161: pg_ctl stop fails sometimes (on Windows) - Mailing list pgsql-bugs

From Tom Lane
Subject Re: BUG #16161: pg_ctl stop fails sometimes (on Windows)
Date
Msg-id 12599.1576786185@sss.pgh.pa.us
Whole thread Raw
In response to Re: BUG #16161: pg_ctl stop fails sometimes (on Windows)  (Alexander Lakhin <exclusion@gmail.com>)
Responses Re: BUG #16161: pg_ctl stop fails sometimes (on Windows)  (Juan José Santamaría Flecha <juanjo.santamaria@gmail.com>)
Re: BUG #16161: pg_ctl stop fails sometimes (on Windows)  (Alexander Lakhin <exclusion@gmail.com>)
Re: BUG #16161: pg_ctl stop fails sometimes (on Windows)  (Kyotaro Horiguchi <horikyota.ntt@gmail.com>)
List pgsql-bugs
Alexander Lakhin <exclusion@gmail.com> writes:
> Maybe we should change the condition to 'if (stat(fileName, &st) != 0 &&
> (err = GetLastError()) == ERROR_ACCESS_DENIED)' to avoid unnecessary
> sleep with a loop iteration...

Well, we have to loop back on file-not-found too ...

> It seems that the check for ERROR_DELETE_PENDING was added to
> pgwin32_safestat() blindly, the issue wasn't reproduced at that time:
> https://www.postgresql.org/message-id/CAB7nPqRJV6trFta-Qzgi6j2feuYR2ZC%2BKHvWdHnbpDG2scTrxw%40mail.gmail.com

Hmm, makes one wonder whether that's actually live code.

            regards, tom lane



pgsql-bugs by date:

Previous
From: Alexander Lakhin
Date:
Subject: Re: BUG #16161: pg_ctl stop fails sometimes (on Windows)
Next
From: Juan José Santamaría Flecha
Date:
Subject: Re: BUG #16161: pg_ctl stop fails sometimes (on Windows)