Re: [HACKERS] [COMMITTERS] pgsql: Generate fmgr prototypes automatically - Mailing list pgsql-hackers

From Tom Lane
Subject Re: [HACKERS] [COMMITTERS] pgsql: Generate fmgr prototypes automatically
Date
Msg-id 12582.1484693616@sss.pgh.pa.us
Whole thread Raw
List pgsql-hackers
Alvaro Herrera <alvherre@2ndquadrant.com> writes:
> Alvaro Herrera wrote:
>> It is possible to replace many occurrences of builtins.h with
>> fmgrprotos.h.  I just tried this
>> git grep -l 'include.*utils/builtins.h' -- *.c | xargs perl -pi -e 's{utils/builtins.h}{utils/fmgrprotos.h}'
>> There's a large number of changes that the oneliner produces that must
>> be reverted for the compile to be silent, but a large portion can
>> remain.  (I only tried src/backend/access).

> 92 files are changed, 241 files still require builtins.h.

Let's hold off on that till we decide on the bigger-picture plan here.
If we're going to try to move those functions out of builtins.h,
this result will change considerably.
        regards, tom lane



pgsql-hackers by date:

Previous
From: "Karl O. Pinc"
Date:
Subject: Re: [HACKERS] Patch to implement pg_current_logfile() function
Next
From: Tomas Vondra
Date:
Subject: Re: [HACKERS] PoC: Grouped base relation