Re: Bug fix for glibc broke freebsd build in REL_11_STABLE - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Bug fix for glibc broke freebsd build in REL_11_STABLE
Date
Msg-id 12522.1543703334@sss.pgh.pa.us
Whole thread Raw
In response to Re: Bug fix for glibc broke freebsd build in REL_11_STABLE  (Andres Freund <andres@anarazel.de>)
Responses Re: Bug fix for glibc broke freebsd build in REL_11_STABLE  (Andres Freund <andres@anarazel.de>)
List pgsql-hackers
Andres Freund <andres@anarazel.de> writes:
> On 2018-12-01 12:06:36 -0500, Tom Lane wrote:
>> I wonder whether we shouldn't remove the clang aspect of the test
>> you added, ie just make it read "if on x86, you must have either
>> -fexcess-precision=standard or -msse2".

> That sounds reasonable.

>> Or should we go so far as to have configure add -msse2 automatically?

> Probably not - there's several OSs / distributions that do not yet
> require an SSE2 capable CPU. While I personally don't care much about
> such machines, I don't think it's worth desupportem them as long as
> mainstream compilers with -fexcess-precision=standard exist.

I guess I wasn't precise enough: I meant add -msse2 if on x86 and
compiler doesn't take -fexcess-precision=standard.

            regards, tom lane


pgsql-hackers by date:

Previous
From: Tatsuo Ishii
Date:
Subject: on or true
Next
From: Andres Freund
Date:
Subject: Re: Bug fix for glibc broke freebsd build in REL_11_STABLE