Broken code in pquery.c - Mailing list pgsql-hackers

From Tom Lane
Subject Broken code in pquery.c
Date
Msg-id 12513.1079645316@sss.pgh.pa.us
Whole thread Raw
Responses Re: Broken code in pquery.c
List pgsql-hackers
The if() statement at line 418 in pquery.c seems a bit bereft of
controlled statement; looks like a broken log_executor_stats patch.
if (portal->strategy != PORTAL_MULTI_QUERY){    ereport(DEBUG3,        (errmsg_internal("PortalRun")));    /*
PORTAL_MULTI_QUERYlogs its own stats per query */    if (log_executor_stats)        ResetUsage();}
 
--->    if (log_executor_stats && portal->strategy != PORTAL_MULTI_QUERY)
/* * Check for improper portal use, and mark portal active. */if (portal->portalDone)    ereport(ERROR,
(errcode(ERRCODE_OBJECT_NOT_IN_PREREQUISITE_STATE),      errmsg("portal \"%s\" cannot be run anymore",
portal->name)));
        regards, tom lane


pgsql-hackers by date:

Previous
From: Larry Rosenman
Date:
Subject: UnixWare/CVS Tip/initdb.c needs to use threads flags...
Next
From: Josh Berkus
Date:
Subject: Authentication drop-down?