Re: pg_archivecleanup debug message consistency - Mailing list pgsql-hackers

From Erik Rijkers
Subject Re: pg_archivecleanup debug message consistency
Date
Msg-id 124bd864c4d32128e96781ae48ebe16e.squirrel@webmail.xs4all.nl
Whole thread Raw
In response to Re: pg_archivecleanup debug message consistency  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: pg_archivecleanup debug message consistency  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
On Sun, August 22, 2010 17:54, Tom Lane wrote:
> "Erik Rijkers" <er@xs4all.nl> writes:
>> If only for consistency, this patch adds the path info to that message.
>
> Seems reasonable, but speaking of consistency:
>
>> +#ifdef WIN32
>> +                snprintf(WALFilePath, MAXPGPATH, "%s\\%s", archiveLocation, exclusiveCleanupFileName);
>> +#else
>> +                snprintf(WALFilePath, MAXPGPATH, "%s/%s", archiveLocation, exclusiveCleanupFileName);
>> +#endif
>
> I see that you copied-and-pasted this pattern from somewhere else in
> pg_archivecleanup.c, but I'd like to argue that it's out of place there
> too.  We don't go out of our way to show Windows paths with backslashes
> anywhere in the core code, so why is pg_archivecleanup doing it?  I
> think we should just drop the ifdef and do %s/%s always.
>

yes, I agree that's better; attached is that change.

And it works fine on linux; but I am not in a position to try it on windows.


Erik Rijkers






Attachment

pgsql-hackers by date:

Previous
From: Peter Eisentraut
Date:
Subject: Re: security label support, part.2
Next
From: Tom Lane
Date:
Subject: UTF16 surrogate pairs in UTF8 encoding