Alvaro Herrera <alvherre@2ndquadrant.com> writes:
> BTW the new castNode() family of macros don't work with Value nodes
> (because the tags are different depending on what's stored, but each
> type does not have its own struct. Oh well.)
Yeah. Value nodes are pretty much of a wart --- it's not clear to me
that they add anything compared to just having a separate node type
for each of the possible subclasses. It's never bothered anyone enough
to try to replace them, though.
I'll take a look at the patch later.
regards, tom lane
