Re: Patch to fix search_path defencies with pg_bench - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Patch to fix search_path defencies with pg_bench
Date
Msg-id 12470.1241809867@sss.pgh.pa.us
Whole thread Raw
In response to Re: Patch to fix search_path defencies with pg_bench  (Greg Smith <gsmith@gregsmith.com>)
List pgsql-hackers
Greg Smith <gsmith@gregsmith.com> writes:
> On Thu, 7 May 2009, Tom Lane wrote:
>> The tables will be created and used in schema 'a', and the effective 
>> search path depth will be the same.

> The case to be concerned about here is where the search_path changes 
> between initialization and the pgbench run, which certainly isn't 
> impossible.  That can leave you with a longer effective path to search. 
> Pretty unlikely to be a problem in the field though.

Yeah.  Also, there is another consideration here that hasn't been
brought up AFAIR: the main point of running pgbench in-the-field
is to find out whether your installation is properly tuned.  If
you've chosen a search_path setting that *did* have some unexpected
performance issues, wouldn't you want pgbench to reveal that?
It's peculiar to have pgbench forcing this one particular GUC setting
and not any others.
        regards, tom lane


pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: [PATCH] Automatic client certificate selection support for libpq v1
Next
From: Ricardo Bessa
Date:
Subject: Show method of index