Re: pgsql/src/interfaces/libpq (fe-connect.c) - Mailing list pgsql-committers

From Tom Lane
Subject Re: pgsql/src/interfaces/libpq (fe-connect.c)
Date
Msg-id 1243.977166440@sss.pgh.pa.us
Whole thread Raw
In response to Re: pgsql/src/interfaces/libpq (fe-connect.c)  (Alfred Perlstein <bright@wintelcom.net>)
List pgsql-committers
Alfred Perlstein <bright@wintelcom.net> writes:
>> Ensure that 'errno' is saved and restored by all signal handlers that
>> might change it.

> I'm not sure why you're doing this, if someone calls PQrequestCancel,
> they shouldn't expect it to preserve errno.

PQrequestCancel is designed and documented to be callable from user
signal handlers, so it seems like good defensive programming to make
it save/restore errno.

            regards, tom lane

pgsql-committers by date:

Previous
From: momjian@postgresql.org
Date:
Subject: pgsql/src/backend/port/dynloader (beos.c)
Next
From: tgl@postgresql.org
Date:
Subject: pgsql/doc/src/sgml (advanced.sgml array.sgml syntax.sgml)