Re: citex regression fails with de.UTF8 locale - Mailing list pgsql-hackers

From Zdenek Kotala
Subject Re: citex regression fails with de.UTF8 locale
Date
Msg-id 1240474384.1275.9.camel@localhost
Whole thread Raw
In response to Re: citex regression fails with de.UTF8 locale  (Heikki Linnakangas <heikki.linnakangas@enterprisedb.com>)
List pgsql-hackers
Heikki Linnakangas píše v čt 23. 04. 2009 v 10:22 +0300:
> Zdenek Kotala wrote:

> Comment and test case fixed. 

Thanks

> I considered changing varstr_cmp to really 
> return -1, 0 or 1, but I didn't because the behavior has been unchanged 
> for ages and all the callers are happy with it. That's a heavily called 
> function so any extra cycles there could make a difference.

I think keep it as it is good decision. strcmp() also does not guarantee
-1, 0, 1.
Zdenek



pgsql-hackers by date:

Previous
From: Heikki Linnakangas
Date:
Subject: Re: New trigger option of pg_standby
Next
From: Sam Halliday
Date:
Subject: RFE: Transparent encryption on all fields