On Sat, 2024-07-27 at 21:08 -0400, Corey Huinker wrote:
>
> Attached is v25.
I attached new versions of 0001 and 0002. Still working on them, so
these aren't final.
v25j-0001:
* There seems to be confusion between the relation for which we are
updating the stats, and pg_class. Permissions and ShareUpdateExclusive
should be taken on the former, not the latter. For consistency with
vac_update_relstats(), RowExclusiveLock should be fine on pg_class.
* Lots of unnecessary #includes were removed.
* I refactored substantially to do basic checks in the SQL function
pg_set_relation_stats() and make calling the internal function easier.
Similar refactoring might not work for pg_set_attribute_stats(), but
that's OK.
* You don't need to declare the SQL function signatures. They're
autogenerated from pg_proc.dat into fmgrprotos.h.
* I removed the inplace stuff for this patch because there's no
coverage for it and it can be easily added back in 0003.
* I renamed the file to import_stats.c. Annoying to rebase, I know,
but better now than later.
v25j-0002:
* I just did some minor cleanup on the #includes and rebased it. I
still need to look in more detail.
Regards,
Jeff Davis
