Re: GetCurrentVirtualXIDs() - Mailing list pgsql-hackers

From Simon Riggs
Subject Re: GetCurrentVirtualXIDs()
Date
Msg-id 1238839426.5444.265.camel@ebony.2ndQuadrant
Whole thread Raw
In response to Re: GetCurrentVirtualXIDs()  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: GetCurrentVirtualXIDs()  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
On Fri, 2009-04-03 at 18:28 -0400, Tom Lane wrote:

> So on third thought I think the patch logic is sound; but I think that
> as documentation we had better add another bool parameter to
> GetCurrentVirtualXIDs indicating whether it's okay to ignore procs
> with xmin = 0.

That sounds better through being more explicit. I didn't consider
whether the patched function was true in all cases, only that it looked
correct in the current usage. Another lesson in future-proofing code.

Thanks also for the clear proof.

-- Simon Riggs           www.2ndQuadrant.comPostgreSQL Training, Services and Support



pgsql-hackers by date:

Previous
From: shrish purohit
Date:
Subject: Extension of Thick Indexes
Next
From: Teodor Sigaev
Date:
Subject: Re: Review: B-Tree emulation for GIN