Re: CI: Add task that runs pgindent - Mailing list pgsql-hackers

From Tom Lane
Subject Re: CI: Add task that runs pgindent
Date
Msg-id 1233967.1762531655@sss.pgh.pa.us
Whole thread Raw
In response to Re: CI: Add task that runs pgindent  (Andres Freund <andres@anarazel.de>)
List pgsql-hackers
Andres Freund <andres@anarazel.de> writes:
> Why does this need to be a separate task, instead of being folded into the
> CompilerWarnings task or such? Increasing the peak numbers of CPUs cfbot needs
> is unfortunately somewhat annoying, as I've been fighting w/ GCP to increase
> the quotas much higher than what they are right now.

We had that discussion upthread, or maybe it was on Discord: we want
to keep formatting complaints separate from actual compiler warnings.
The latter should be fixed before the patch can be considered ready,
whereas pgindent might get left for the committer to do.  An example
where that's actually good practice is where the patch has to reindent
a chunk of existing code; submitting it without that makes review
simpler.

            regards, tom lane



pgsql-hackers by date:

Previous
From: Andrei Lepikhov
Date:
Subject: Re: Sequence Access Methods, round two
Next
From: Jim Jones
Date:
Subject: Re: [PATCH] Add pg_get_tablespace_ddl() function to reconstruct CREATE TABLESPACE statement