Re: Hot standby, RestoreBkpBlocks and cleanup locks - Mailing list pgsql-hackers

From Simon Riggs
Subject Re: Hot standby, RestoreBkpBlocks and cleanup locks
Date
Msg-id 1232037256.31921.57.camel@ebony.2ndQuadrant
Whole thread Raw
In response to Re: Hot standby, RestoreBkpBlocks and cleanup locks  (Heikki Linnakangas <heikki.linnakangas@enterprisedb.com>)
List pgsql-hackers
On Thu, 2009-01-15 at 18:05 +0200, Heikki Linnakangas wrote:
> Simon Riggs wrote:
> > The idea outlined before didn't deal with all call points for
> > RecordIsCleanupRecord(), so doesn't actually work.
> 
> Are we talking about the same thing? 

I guess not. Look at the other call points for that function, cos your
suggestion didn't include them AFAICS.

> If we put the control of locking to 
> the hands of the redo-function, I don't see why it couldn't use a lock 
> of the right strength. Surely the redo-function can be taught what lock 
> it needs to take.

Yes, it can, but there were other uses.

-- Simon Riggs           www.2ndQuadrant.comPostgreSQL Training, Services and Support



pgsql-hackers by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: FWD: Re: Updated backslash consistency patch
Next
From: Tom Lane
Date:
Subject: Re: FWD: Re: Updated backslash consistency patch