Re: incorrect xlog.c coverage report - Mailing list pgsql-hackers

From Tom Lane
Subject Re: incorrect xlog.c coverage report
Date
Msg-id 12312.1542824448@sss.pgh.pa.us
Whole thread Raw
In response to Re: incorrect xlog.c coverage report  (Alvaro Herrera <alvherre@2ndquadrant.com>)
Responses Re: incorrect xlog.c coverage report
List pgsql-hackers
Alvaro Herrera <alvherre@2ndquadrant.com> writes:
> On 2018-Nov-21, Masahiko Sawada wrote:
>> I've looked into this issue and this happens on my environment (CentOS
>> 6.9 and gcob 4.4.7) as well. ISTM the cause would related to the
>> immediate shutdown mode we're using in test_recovery_standby.

Doh, of course.

> I think we should change all calls of ->teardown_node to ->stop(),
> except the one in the END block, and look for places which are currently
> relying too much on END (i.e. add more ->stop() calls where needed).

Hm.  We probably don't want to have zero coverage of immediate stop mode,
though I agree we could cut it way back.

            regards, tom lane


pgsql-hackers by date:

Previous
From: Andrew Dunstan
Date:
Subject: Re: [RFC] Removing "magic" oids
Next
From: Alvaro Herrera
Date:
Subject: Re: pgsql: instr_time.h: add INSTR_TIME_SET_CURRENT_LAZY