Re: Reorganize GUC structs - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Reorganize GUC structs
Date
Msg-id 1227178.1762528495@sss.pgh.pa.us
Whole thread Raw
In response to Re: Reorganize GUC structs  (Peter Eisentraut <peter@eisentraut.org>)
List pgsql-hackers
Peter Eisentraut <peter@eisentraut.org> writes:
> Here are a few more small patches to fix related things I found
> afterwards or in passing.

Looks sane, except that the comparator could do with an extra "const"
if there's enough room on the line:

+    const struct config_generic *ca = *(const struct config_generic *const *) a;
+    const struct config_generic *cb = *(const struct config_generic *const *) b;

Not essential, but casting const away even transiently looks ugly.

            regards, tom lane



pgsql-hackers by date:

Previous
From: Andres Freund
Date:
Subject: Re: LTO aggressively optimizing out function despite explicit calls in logical decoding
Next
From: "Maksim.Melnikov"
Date:
Subject: Re: Incorrect checksum in control file with pg_rewind test