Re: Re: Hot standby v5 patch - Databases created post backup remain inaccessible + replica SIGSEGV when coming out of standby - Mailing list pgsql-hackers

From Simon Riggs
Subject Re: Re: Hot standby v5 patch - Databases created post backup remain inaccessible + replica SIGSEGV when coming out of standby
Date
Msg-id 1225891511.17744.64.camel@ebony.2ndQuadrant
Whole thread Raw
In response to Re: Hot standby v5 patch - Databases created post backup remain inaccessible + replica SIGSEGV when coming out of standby  (Simon Riggs <simon@2ndQuadrant.com>)
List pgsql-hackers
On Tue, 2008-11-04 at 09:52 +0000, Simon Riggs wrote:

> > postgres=# \c bench
> > FATAL:  database "bench" does not exist
> > Previous connection kept
> 
> CREATE DATABASE didn't trigger the db flat file update, code for which
> existed and was triggered in the cases when a transaction would normally
> rebuild the flat files. Simple fix, but stupid oversight. 

Issue resolved.

> Spotted another problem which is that BuildFlatFile may not be built
> consistently if a rebuild is triggered prior to us reaching the recovery
> consistency point. This is fixed by forcing a rebuild of the flat files
> when we hit the recovery point.

Issue resolved.

> Both one line changes, but I'll go looking for other issues there.

I also mentioned previously that I hadn't implemented locking yet during
flat file updates. After spending longer looking at the code around this
I no longer think it is required.

These changes will be rolled into the next patch version, soon.

-- Simon Riggs           www.2ndQuadrant.comPostgreSQL Training, Services and Support



pgsql-hackers by date:

Previous
From: Joshua Tolley
Date:
Subject: Re: Proposed Patch to Improve Performance of Multi-Batch Hash Join for Skewed Data Sets
Next
From: Zdenek Kotala
Date:
Subject: Re: [WIP] In-place upgrade