Re: pgsql: Add support for hyperbolic functions, as well as log10(). - Mailing list pgsql-hackers

From Tom Lane
Subject Re: pgsql: Add support for hyperbolic functions, as well as log10().
Date
Msg-id 1225.1552531470@sss.pgh.pa.us
Whole thread Raw
In response to Re: pgsql: Add support for hyperbolic functions, as well as log10().  (Robert Haas <robertmhaas@gmail.com>)
List pgsql-hackers
Robert Haas <robertmhaas@gmail.com> writes:
> On Wed, Mar 13, 2019 at 10:39 PM Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> No, but that's not the hazard.  I have a very fresh-in-mind example:
>> at one point while tweaking Laetitia's patch, I'd accidentally changed
>> datanh so that it called tanh not atanh.  The previous set of tests did
>> not reveal that :-(

> Well, that was a goof, but it's not likely that such a regression will
> ever be reintroduced.

Sure, but how about this for another example: maybe a given platform
hasn't got these functions (or they're in a different library we
didn't pull in), but you don't see a failure until you actually
call them.  We try to set up our link options so that that sort
of failure is reported at build time, but I wouldn't care to bet
that we've succeeded at that everywhere.

            regards, tom lane


pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: pgsql: Add support for hyperbolic functions, as well as log10().
Next
From: Kyotaro HORIGUCHI
Date:
Subject: Re: Progress reporting for pg_verify_checksums