Request a Demo
Home   >   mailing lists

Re: [PATCH] Free memory allocated by waitonlock_error_callback() - Mailing list pgsql-hackers

From Tom Lane
Subject Re: [PATCH] Free memory allocated by waitonlock_error_callback()
Date
Msg-id 1222758.1761193775@sss.pgh.pa.us
Whole thread Raw
In response to Re: [PATCH] Free memory allocated by waitonlock_error_callback()  (Michael Paquier <michael@paquier.xyz>)
Responses Re: [PATCH] Free memory allocated by waitonlock_error_callback()
List pgsql-hackers
Tree view 
Michael Paquier <michael@paquier.xyz> writes:
> On Thu, Oct 23, 2025 at 11:18:09AM +0800, Quan Zongliang wrote:
>> Improve the completeness of the code.

> errfinish() calls MemoryContextReset() on ErrorContext so as any leaks
> like the one you are cleaning up are taken care of.  Still, what you
> are suggesting is simple enough and silences a bit valgrind, so agreed
> about the addition of this pfree().

> Let's see if somebody objects to that.

Yeah, I object.  Didn't 89d57c1fb already solve this in a more
general way?  If it's not fixed by that, why not?

            regards, tom lane

pgsql-hackers by date:

Previous
From: jian he
Date:
Subject: Re: [PATCH] pg_get_domain_ddl: DDL reconstruction function for CREATE DOMAIN statement
Next
From: Fujii Masao
Date:
Subject: Re: Fix lag columns in pg_stat_replication not advancing when replay LSN stalls