Postgres Pro
Downloads
Home   >   mailing lists

Re: Dubious code in pg_rewind's process_target_file() - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Dubious code in pg_rewind's process_target_file()
Date
Msg-id 1222282.1599329909@sss.pgh.pa.us
Whole thread Raw
In response to Dubious code in pg_rewind's process_target_file()  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: Dubious code in pg_rewind's process_target_file()
List pgsql-hackers
Tree view 
I wrote:
> It looks to me like we could replace "exists = false" with "return",
> rather than uselessly constructing a FILE_ACTION_REMOVE entry for
> a file we've already proven is not there.

Or actually, maybe we should just drop the lstat call altogether?
AFAICS it's 99.99% redundant with the lstat that traverse_datadir
has done nanoseconds before.  Yeah, maybe somebody managed to drop
the file in between, but the FILE_ACTION_REMOVE code would have to
deal with such cases anyway in case a drop occurs later.

            regards, tom lane

pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Dubious code in pg_rewind's process_target_file()
Next
From: Ranier Vilela
Date:
Subject: Re: A micro-optimisation for walkdir()