Re: pgsql: Fix a couple of problems pointed out by Fujii Masao in the - Mailing list pgsql-committers

From Simon Riggs
Subject Re: pgsql: Fix a couple of problems pointed out by Fujii Masao in the
Date
Msg-id 1220894913.3913.212.camel@ebony.2ndQuadrant
Whole thread Raw
In response to pgsql: Fix a couple of problems pointed out by Fujii Masao in the  (tgl@postgresql.org (Tom Lane))
Responses Re: pgsql: Fix a couple of problems pointed out by Fujii Masao in the
List pgsql-committers
On Mon, 2008-09-08 at 16:42 +0000, Tom Lane wrote:
> Log Message:
> -----------
> Fix a couple of problems pointed out by Fujii Masao in the 2008-Apr-05 patch
> for pg_stop_backup.

Thanks. Just a couple of notes there:

> First, it is possible that the history file name is not

...always...

> alphabetically later than the last WAL file name, so we should explicitly
> check that both have been archived.

My test case for the original patch worked, though there were other
cases also.

> Second, the previous coding would wait
> forever if a checkpoint had managed to remove the WAL file before we look for
> it.

The original code was safe from this error. That point applies to
discussion of solution to the first point.

--
 Simon Riggs           www.2ndQuadrant.com
 PostgreSQL Training, Services and Support


pgsql-committers by date:

Previous
From: tgl@postgresql.org (Tom Lane)
Date:
Subject: pgsql: Fix a couple of problems pointed out by Fujii Masao in the
Next
From: "Fujii Masao"
Date:
Subject: Re: pgsql: Fix a couple of problems pointed out by Fujii Masao in the