Re: [PATCH] Cleanup of GUC units code - Mailing list pgsql-hackers

From Hannu Krosing
Subject Re: [PATCH] Cleanup of GUC units code
Date
Msg-id 1220472624.7603.2.camel@huvostro
Whole thread Raw
In response to Re: [PATCH] Cleanup of GUC units code  (Alvaro Herrera <alvherre@commandprompt.com>)
Responses Re: [PATCH] Cleanup of GUC units code  (Joshua Drake <jd@commandprompt.com>)
Re: [PATCH] Cleanup of GUC units code  (Alvaro Herrera <alvherre@commandprompt.com>)
List pgsql-hackers
On Wed, 2008-09-03 at 13:48 -0400, Alvaro Herrera wrote:
> Hannu Krosing escribió:
> > On Wed, 2008-09-03 at 09:10 -0700, Joshua Drake wrote:
> 
> > > If we are going to make sweeping statements (anyone on this thread)
> > > about user-hostile and most people, then we better define what those
> > > mean. 
> > 
> > Not user-hostile but rather hostile to an overworked DBA, who tries to
> > change some .conf param from 1MB to 512KB at 3AM to save an overloaded
> > server and then suddenly the server won't start anymore.
> 
> I think the energy wasted in this discussion would be better spent in
> working a the check-the-config-file feature.

What kind of checks do you have in mind. Would this be something that
works at restart, does the check and continues with old settings if new
file would not load ?

> That would equally solve
> this problem, as well as many others.

AFAIK the config file is checked now, and if the check fails, the
database won't start.

-------------
Hannu




pgsql-hackers by date:

Previous
From: Joshua Drake
Date:
Subject: Re: [patch] GUC source file and line number]
Next
From: Joshua Drake
Date:
Subject: Re: [PATCH] Cleanup of GUC units code