Re: A GUC variable to replace PGBE_ACTIVITY_SIZE - Mailing list pgsql-patches

From Neil Conway
Subject Re: A GUC variable to replace PGBE_ACTIVITY_SIZE
Date
Msg-id 1214244728.13041.32.camel@dell.linuxdev.us.dell.com
Whole thread Raw
In response to A GUC variable to replace PGBE_ACTIVITY_SIZE  (Thomas Lee <tom@vector-seven.com>)
List pgsql-patches
On Mon, 2008-06-23 at 03:52 +1000, Thomas Lee wrote:
> * Should it be possible to set this new variable via a command-line
> option ala shared_buffers?

I would say not: most parameters cannot be set by special command-line
parameters, and this one is not important enough to warrant special
treatment. Instead, "--track_activity_query_size=x" can be used as-is.

> * I'm not exactly sure about the best way to add unit/regr tests for
> this change.

AFAICS there isn't an easy way.

> * I'm also not sure what's required in the way of updates to the
> documentation.

postgresql.conf.sample and doc/src/sgml/config.sgml should be updated at
a minimum.

-Neil



pgsql-patches by date:

Previous
From: Tom Lane
Date:
Subject: Re: variadic function support
Next
From: Bruce Momjian
Date:
Subject: Re: Simplify formatting.c