Postgres Pro
Downloads
Home   >   mailing lists

Re: pgsql: Report which WAL sync method we are trying to change *to* when it - Mailing list pgsql-committers

From Simon Riggs
Subject Re: pgsql: Report which WAL sync method we are trying to change *to* when it
Date
Msg-id 1210621572.29684.197.camel@ebony.site
Whole thread Raw
In response to Re: pgsql: Report which WAL sync method we are trying to change *to* when it  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: pgsql: Report which WAL sync method we are trying to change *to* when it
Re: pgsql: Report which WAL sync method we are trying to change *to* when it
List pgsql-committers
Tree view 
On Mon, 2008-05-12 at 15:26 -0400, Tom Lane wrote:
> Magnus Hagander <magnus@hagander.net> writes:
> > Simon Riggs wrote:
> >> Could we report both?
>
> > Yes, we could easily do that if we want to.
>
> It would be entirely silly to do so, since (a) the old value hasn't been
> changed if we fail here, and (b) it's irrelevant to the nature of the
> error.

That's reasonable. If it is impossible to set it to an
impossible/failing value then that is even better.

Magnus seems to say it is possible to set this and then have it fail
later when it is used. Not sure which is correct.

--
  Simon Riggs
  2ndQuadrant  http://www.2ndQuadrant.com

pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: Re: pgsql: Report which WAL sync method we are trying to change *to* when it
Next
From: mha@postgresql.org (Magnus Hagander)
Date:
Subject: pgsql: Fix breakage by the wal_sync_method patch in installations that