Re: Replace run-time error check with assertion - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Replace run-time error check with assertion
Date
Msg-id 1210610.1621954283@sss.pgh.pa.us
Whole thread Raw
In response to Replace run-time error check with assertion  (Peter Eisentraut <peter.eisentraut@enterprisedb.com>)
List pgsql-hackers
Peter Eisentraut <peter.eisentraut@enterprisedb.com> writes:
> In the attached patch, the error message was checking that the 
> structures returned from the parser matched expectations.  That's 
> something we usually use assertions for, not a full user-facing error 
> message.  So I replaced that with an assertion (hidden inside 
> lfirst_node()).

Works for me.  It's certainly silly to use a translatable ereport
rather than elog for this.

Localizing those variables some more looks sane too.

            regards, tom lane



pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: pg_rewind fails if there is a read only file.
Next
From: Tom Lane
Date:
Subject: Re: CALL versus procedures with output-only arguments