Re: VacAttrStatsP vs VacAttrStats * (typedef'ing pointer types) - Mailing list pgsql-hackers

From Neil Conway
Subject Re: VacAttrStatsP vs VacAttrStats * (typedef'ing pointer types)
Date
Msg-id 1209765181.22465.11.camel@dell.linuxdev.us.dell.com
Whole thread Raw
In response to VacAttrStatsP vs VacAttrStats * (typedef'ing pointer types)  (Jan Urbański <j.urbanski@students.mimuw.edu.pl>)
List pgsql-hackers
On Fri, 2008-05-02 at 23:22 +0200, Jan Urbański wrote:
> While looking around vacuum.h (for my GSoC project) I found:
> typedef struct VacAttrStats *VacAttrStatsP;
> and then throughout the code sometimes VacAttrStats *foo is used and 
> sometimes VacAttrStatsP bar is used.

Personally I think we should be consistent about this and just use one
form for a given type.

(I don't really care which variant is preferred. Personally, I think
that hiding pointer types inside a typedef is evil and wrong, but it is
relatively common practice in the source...)

-Neil




pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Protection from SQL injection
Next
From: Tom Lane
Date:
Subject: Re: VacAttrStatsP vs VacAttrStats * (typedef'ing pointer types)