Re: pg_standby for 8.2 (with last restart point) - Mailing list pgsql-hackers

From Simon Riggs
Subject Re: pg_standby for 8.2 (with last restart point)
Date
Msg-id 1206696903.4285.1509.camel@ebony.site
Whole thread Raw
In response to Re: pg_standby for 8.2 (with last restart point)  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
On Fri, 2008-03-28 at 00:54 -0400, Tom Lane wrote:
> Greg Smith <gsmith@gregsmith.com> writes:
> > ... That was a small change in a utility that should never be run on a
> > production system.  You're trying to get a change made to the code path
> > people rely on for their *backups*.  Good luck with that.
>
> While I quite agree with Greg's comments about not changing stable
> release branches unnecessarily, it seems that there's another
> consideration in this case.  If we don't back-patch %r then users
> will have to rely on hacky scripts like the one posted upthread.
> Is that really a net gain in reliability?
>
> (I'm honestly not sure of the answer; I'm just thinking it might
> be open to debate.  In particular I don't remember how complicated
> the patch to add %r was.)

Here's the original patch, edited to remove pg_standby changes.

I've not even checked whether it will apply, but it seems fairly simple.

Gurjeet, would you like to freshen and test that up for apply to 8.2?

--
  Simon Riggs
  2ndQuadrant  http://www.2ndQuadrant.com

  PostgreSQL UK 2008 Conference: http://www.postgresql.org.uk

Attachment

pgsql-hackers by date:

Previous
From: Gregory Stark
Date:
Subject: Commitfest patches
Next
From: Simon Riggs
Date:
Subject: Re: Commitfest patches