Re: Fix bug in multixact Oldest*MXactId initialization and access - Mailing list pgsql-hackers

From Yura Sokolov
Subject Re: Fix bug in multixact Oldest*MXactId initialization and access
Date
Msg-id 120550bf-ca50-4a07-91b1-a88f1434ee8b@postgrespro.ru
Whole thread Raw
In response to Re: Fix bug in multixact Oldest*MXactId initialization and access  (Sami Imseih <samimseih@gmail.com>)
Responses Re: Fix bug in multixact Oldest*MXactId initialization and access
List pgsql-hackers
02.03.2026 22:09, Sami Imseih пишет:
>>> It says “Each is indexed by ProcNumber”, but it’s no longer accurate for OldestMemberMXactId prepared-xact entries,
whichnow use index (procno - FIRST_PREPARED_XACT_PROC_NUMBER).
 
>>
>> Fixed those and some other comment work, and pushed. Thanks!
>>
> 
> Thanks! what are your thoughts about adding a test like the one
> here [1] ? This allows us to test correct handling of prepared
> transaction dummy procs. The asserts added will not cover
> this case.
> 
> What do you think?
> 
> [1] [https://www.postgresql.org/message-id/CAA5RZ0twq5bNMq0r0QNoopQnAEv%2BJ3qJNCrLs7HVqTEntBhJ%3Dg%40mail.gmail.com]
I support: test for bug fixed is a good thing.

-- 
regards
Yura Sokolov aka funny-falcon



pgsql-hackers by date:

Previous
From: Chao Li
Date:
Subject: Re: Cleanup shadows variable warnings, round 1
Next
From: Jaroslav Novikov
Date:
Subject: Re: Streaming replication and WAL archive interactions