Re: Typo in bufmgr.c that result in waste of memory - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Typo in bufmgr.c that result in waste of memory
Date
Msg-id 12045.1455889328@sss.pgh.pa.us
Whole thread Raw
In response to Re: Typo in bufmgr.c that result in waste of memory  (Simon Riggs <simon@2ndQuadrant.com>)
Responses Re: Typo in bufmgr.c that result in waste of memory
List pgsql-hackers
Simon Riggs <simon@2ndQuadrant.com> writes:
> I see the problem, but I don't buy the argument that it wastes large
> amounts of memory. Or do you have some evidence that it does?

Agreed, it seems unlikely that that hash table gets large enough for
this to be really significant.  Still ...

> I think we should fix it, but not backpatch.

I don't think that's particularly good policy.  It's a clear bug, why
would we not fix it?  Leaving it as-is in the back branches can have
no good effect, and what it does do is create a merge hazard for other
back-patchable bug fixes in the same area.
        regards, tom lane



pgsql-hackers by date:

Previous
From: Amit Kapila
Date:
Subject: Re: Re: BUG #13685: Archiving while idle every archive_timeout with wal_level hot_standby
Next
From: Andres Freund
Date:
Subject: Re: Typo in bufmgr.c that result in waste of memory