Re: nodeAgg perf tweak - Mailing list pgsql-hackers

From Tom Lane
Subject Re: nodeAgg perf tweak
Date
Msg-id 1202.1101874534@sss.pgh.pa.us
Whole thread Raw
In response to nodeAgg perf tweak  (Neil Conway <neilc@samurai.com>)
Responses Re: nodeAgg perf tweak
List pgsql-hackers
Neil Conway <neilc@samurai.com> writes:
> I've attached a quick and dirty hack that avoids the need to palloc()
> and pfree() for every tuple produced by the aggregate's transition
> function.

And how badly does it leak memory?  I do not believe this patch is
tenable.

Something that occurred to me the other morning in the shower is that we
could trivially inline MemoryContextSwitchTo() when using gcc, much as
you did for list_length().  I haven't gotten around to doing it but it
seems like a free percent-or-two improvement.
        regards, tom lane


pgsql-hackers by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: Increasing the length of
Next
From: Bruce Momjian
Date:
Subject: Re: libpq and psql not on same page about SIGPIPE