Re: pgsql: Fix an ancient oversight in libpq's handling of V3-protocol COPY - Mailing list pgsql-committers

From Simon Riggs
Subject Re: pgsql: Fix an ancient oversight in libpq's handling of V3-protocol COPY
Date
Msg-id 1200430962.4266.1792.camel@ebony.site
Whole thread Raw
In response to pgsql: Fix an ancient oversight in libpq's handling of V3-protocol COPY  (tgl@postgresql.org (Tom Lane))
Responses Re: pgsql: Fix an ancient oversight in libpq's handling of V3-protocol COPY  (Alvaro Herrera <alvherre@commandprompt.com>)
List pgsql-committers
On Mon, 2008-01-14 at 18:46 +0000, Tom Lane wrote:
> Log Message:
> -----------
> Fix an ancient oversight in libpq's handling of V3-protocol COPY OUT mode:
> we need to be able to swallow NOTICE messages, and potentially also
> ParameterStatus messages (although the latter would be a bit weird),
> without exiting COPY OUT state.  Fix it, and adjust the protocol documentation
> to emphasize the need for this.  Per off-list report from Alexander Galler.

My reading of this is that previously a PQgetCopyData() operation would
fail mysteriously because of

i) a reload of postgresql.conf, following the setting of any of the
following parameters client_encoding, DateStyle, TimeZone, and
standard_conforming_strings.

ii) any previous LISTEN command on the session running the COPY

Would that be correct? Did I miss anything?

--
  Simon Riggs
  2ndQuadrant  http://www.2ndQuadrant.com


pgsql-committers by date:

Previous
From: tgl@postgresql.org (Tom Lane)
Date:
Subject: pgsql: Revise memory management for libxml calls.
Next
From: tgl@postgresql.org (Tom Lane)
Date:
Subject: pgsql: Prevent CLUSTER from decreasing a relation's relfrozenxid.