Re: Revised patch for fixing archiver shutdown behavior - Mailing list pgsql-patches

From Simon Riggs
Subject Re: Revised patch for fixing archiver shutdown behavior
Date
Msg-id 1199980384.4266.770.camel@ebony.site
Whole thread Raw
In response to Re: Revised patch for fixing archiver shutdown behavior  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-patches
On Thu, 2008-01-10 at 10:13 -0500, Tom Lane wrote:
> Alvaro Herrera <alvherre@commandprompt.com> writes:
> > Something I'm still wondering is about the archiver/logger combination.
> > What happens if a postmaster is stopped by the user and the archiver is
> > still running, and the user starts a new postmaster?  This would launch
> > a new archiver and logger; and there are now two loggers possibly
> > writing to the same files, and truncated log lines could occur.
>
> I'm not nearly as worried about that as I am about the prospect of
> two concurrent archivers :-(

How strange, I was just looking at that particular possibility when your
mail arrived.

The earlier patch looks good, but I see you've reverted the
PostmasterIsAlive() check in pgarch_ArchiverCopyLoop(). That was put in
to prevent multiple archivers. Can we keep that?

--
  Simon Riggs
  2ndQuadrant  http://www.2ndQuadrant.com


pgsql-patches by date:

Previous
From: Tom Lane
Date:
Subject: Re: Revised patch for fixing archiver shutdown behavior
Next
From: Simon Riggs
Date:
Subject: Re: Revised patch for fixing archiver shutdown behavior