Postgres Pro
Downloads
Home   >   mailing lists

Re: pgsql: Re-enable the old code in xlog.c that tried to use - Mailing list pgsql-committers

From Tom Lane
Subject Re: pgsql: Re-enable the old code in xlog.c that tried to use
Date
Msg-id 1194.1231701720@sss.pgh.pa.us
Whole thread Raw
In response to Re: pgsql: Re-enable the old code in xlog.c that tried to use  (Gregory Stark <greg.stark@enterprisedb.com>)
List pgsql-committers
Tree view 
Gregory Stark <greg.stark@enterprisedb.com> writes:
> tgl@postgresql.org (Tom Lane) writes:
> ! #if defined(USE_POSIX_FADVISE) && defined(POSIX_FADV_DONTNEED)

> I think if we're not putting the AC_CHECK_RUN check in then this should just
> be HAVE_POSIX_FADVISE not USE_POSIX_FADVISE. The latter was the define I made
> if the run check passed.

No, checking the DECL part as well is critical (if we don't see a
declaration we risk ABI incompatibility).  And in any case I'm insisting
on being able to turn this off in pg_config_manual.h.

            regards, tom lane

pgsql-committers by date:

Previous
From: Gregory Stark
Date:
Subject: Re: pgsql: Re-enable the old code in xlog.c that tried to use
Next
From: tgl@postgresql.org (Tom Lane)
Date:
Subject: pgsql: Implement prefetching via posix_fadvise() for bitmap index scans.